D15061: [xwl] Generic X selections translation mechanism with Clipboard support

romangg added inline comments.

INLINE COMMENTS

> zzag wrote in databridge.cpp:95-101
> The lambda is superfluous.

See D15627 <https://phabricator.kde.org/D15627>

> zzag wrote in selection.cpp:132
> Is compiler happy about this?

Spills out warnings. It's similar to how Weston and wlroots does it though, so I don't want to increase difference to them here in this first version. Let's revisit it later though.

Or do you have directly a simple solution for it?

> zzag wrote in selection.cpp:234
> Can't we do qobject_cast<Client *>(workspace()->activeClient()) == nullptr?

Have to include client.h for that. But let's do it.

> zzag wrote in selection_source.h:135
> Could you please explain why you use QVector<QString> instead of QStringList?

In general if possible QVector should be preferred over QList according to Qt doc.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15061

To: romangg, #kwin
Cc: zzag, graesslin, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart