D17928: [RFC] [Effects KCM] Port to QQC2

davidedmundson added inline comments.

INLINE COMMENTS

> EffectView.qml:45
>              text: i18n("Hint: To find out or configure how to activate an effect, look at the effect's settings.")
> -            anchors {
> -                top: parent.top
> -                left: parent.left
> -            }
> +            Layout.fillWidth: true
> +            Layout.alignment: Qt.AlignLeft

good fix!

> EffectView.qml:68
> +                y: configureButton.height
> +                x: parent.width - width
> +                MenuItem {

In RTL is this correct?

> EffectView.qml:92
> +            clip: true
>              ListView {
>                  function exclusiveGroupForCategory(category) {

For the borders add this to the ScrollView

Component.onCompleted: background.visible = true;

> EffectView.qml:146
> +                        color: searchModel.sectionColor
> +                        anchors.horizontalCenter: parent.horizontalCenter
> +                    }

I know you've just moved this, but this is messy.

You can't specify x and an horizontal anchor.

It should be fill horizontally and use Text.alignment

Though we can fix after.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17928

To: ngraham, #kwin, #plasma
Cc: davidedmundson, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart