D17943: [effects/slideback] Port away from deprecated EffectWindow::desktop

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Not only does the function windowsShareDesktop become a lot more complex
  with the new desktop cardinality comparing if they share any desktop
  isn't actually what we want.
  
  If I have 2 windows on desktop 1 and the lower stacked window is also on
  desktop 2, when I switch desktops the focus will change, but we don't
  want to animate anything here as on this dekstop it has nothing to slide
  in front of.
  
  Instead this patch simply checks both windows are on the current
  desktop.

TEST PLAN
  Loaded a few windows. Some on one, some on more.
  Before if a window was on desktop 1&2 it wouldn't animate on 2.
  
  Windows now seem to animate when they should and not when they shouldn't.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17943

AFFECTED FILES
  effects/slideback/slideback.cpp

To: davidedmundson, #kwin
Cc: kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart