D17989: [autotests] Avoid useless waits in testToplevelOpenCloseAnimation
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.
REVISION SUMMARY
Use QTRY_VERIFY instead of qWait + QVERIFY to avoid useless waits.
Effects like scale or glide don't last longer than 200ms.
TEST PLAN
Before:
$ dbus-run-session ctest -R testToplevelOpenCloseAnimation
Test project /home/vlad/Workspace/KDE/build/kde/workspace/kwin
Start 123: kwin-testToplevelOpenCloseAnimation
1/2 Test #123: kwin-testToplevelOpenCloseAnimation ............... Passed 6.43 sec
Start 124: kwin-testToplevelOpenCloseAnimation-waylandonly
2/2 Test #124: kwin-testToplevelOpenCloseAnimation-waylandonly ... Passed 6.33 sec
100% tests passed, 0 tests failed out of 2
Total Test time (real) = 12.76 sec
After:
$ dbus-run-session ctest -R testToplevelOpenCloseAnimation
Test project /home/vlad/Workspace/KDE/build/kde/workspace/kwin
Start 123: kwin-testToplevelOpenCloseAnimation
1/2 Test #123: kwin-testToplevelOpenCloseAnimation ............... Passed 2.05 sec
Start 124: kwin-testToplevelOpenCloseAnimation-waylandonly
2/2 Test #124: kwin-testToplevelOpenCloseAnimation-waylandonly ... Passed 2.00 sec
100% tests passed, 0 tests failed out of 2
Total Test time (real) = 4.05 sec
REPOSITORY
R108 KWin
BRANCH
avoid-useless-waits
REVISION DETAIL
https://phabricator.kde.org/D17989
AFFECTED FILES
autotests/integration/effects/toplevel_open_close_animation_test.cpp
To: zzag, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart