D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Can confirm reduced awfulness. But while you're at it, why not make it entirely non-awful? :)  The problem here is the tiny tiny tiny drag area in the fake titlebar. I think the height of the fake titlebar could be increased by a factor of 2 or even 3, which would make this UI much more pleasant to use.

INLINE COMMENTS

> ButtonGroup.qml:52
>              id: dragArea
> -            cursorShape: Qt.PointingHandCursor
> +            cursorShape: Qt.DragMoveCursor
>              anchors.fill: parent

This cursor should only be used when actually dragging (i.e. when the mouse is down), not when a drag is merely //possible//. For that, a more appropriate cursor might be `Qt.SizeAllCursor`.

> Buttons.qml:178
>                          drag.target: availableButton
> -                        cursorShape: Qt.PointingHandCursor
> +                        cursorShape: Qt.DragMoveCursor
>                          onReleased: {

Same

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17982

To: vpilo, #vdg, #kwin, ngraham
Cc: ngraham, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart