D18015: Ensure the Compositor does not start during termination

graesslin created this revision.
graesslin added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
graesslin requested review of this revision.

REVISION SUMMARY
  The SceneOpenGLES test was starting to randomly crash on my system. On
  investigation I observed that there was a graphics reset ("Attempting to
  reset compositing.") which triggered a delayed restart of the
  compositor. This even was only processed while waiting for XWayland to
  terminate. Which resulted in a crash in KWin::getXServerVersion as the
  xcb connection broke.
  
  It makes no sense to setup the compositor again during application
  shutdown. Thus the dtors set a flag that they are terminating the
  application and Compositor::setup is checking for it.

TEST PLAN
  Test no longer crashes, although it goes through the crashing path

REPOSITORY
  R108 KWin

BRANCH
  compositor-dont-setup-on-termination

REVISION DETAIL
  https://phabricator.kde.org/D18015

AFFECTED FILES
  autotests/integration/kwin_wayland_test.cpp
  composite.cpp
  main.h
  main_wayland.cpp
  main_x11.cpp

To: graesslin, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart