D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

davidedmundson added inline comments.

INLINE COMMENTS

> Buttons.qml:54
> +                Layout.fillWidth: true
> +                Layout.topMargin: -border.width
>                  RowLayout {

what's this about?

> Buttons.qml:145
>                  interactive: false
> -                cellWidth: iconLabel.implicitWidth
> -                cellHeight: units.iconSizes.small + iCannotBelieveIDoThis.implicitHeight + 4*units.smallSpacing
> -                height: Math.ceil(cellHeight * 2.5)
> +                height: Math.ceil(cellHeight * 3)
>                  delegate: Item {

It still makes sense to calculate this from the icon and text like before.

(Though with QFontMetrics instead of fake Text elements)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17982

To: vpilo, #vdg, #kwin, ngraham
Cc: davidedmundson, ngraham, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart