D17982: [kcmkwin/kwindecoration] Fix visuals of KCM decorations' buttons tab

Valerio Pilo <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
vpilo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Buttons.qml:54
> what's this about?

Without this, the top border of the fake window is double thickness, since it's actually two borders (the whole window + the titlebar).
I couldn't find less depressing way to fix it.

> davidedmundson wrote in Buttons.qml:145
> It still makes sense to calculate this from the icon and text like before.
> 
> (Though with QFontMetrics instead of fake Text elements)

How so? From kcm.cpp via a property? Or the TextMetrics QML type?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17982

To: vpilo, #vdg, #kwin, ngraham
Cc: davidedmundson, ngraham, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.