D15627: [xwl] Drag and drop between Xwayland and Wayland native clients

romangg added inline comments.

INLINE COMMENTS

> zzag wrote in input.cpp:2095
> The name is confusing. Currently, it implies that this method looks for a managed client, which seams not the case.

Why is it not the case? In the stacking_order only the managed ones are, not?

> zzag wrote in clipboard.cpp:139
> nullptr

It takes an xcb_xfixes_selection_notify_event_t struct pointer included from xcb/xfixes.h. When I reuse components from X libraries I use the legacy NULL, because I remember that it can lead to problem if one doesn't and then gives it back to a function from such a library.

> zzag wrote in clipboard.cpp:142
> Isn't qobject_cast preferred over bool inherits(const char *className) const?

Could be. Qt doc is not clear on it. I will change it though.

> zzag wrote in dnd.h:78
> According to the coding style, we should put a whitespace before "*", though both variants are okay.

Yea, I just find it looks weird, when there is no variable name after it, so when I just write it together.

> zzag wrote in drag.cpp:56
> Delete it?

Would leave it as a reminder for now. If we don't have any clients making use of it, we can delete it till end of year.

> zzag wrote in drag.h:39
> /**

Thanks, looks better in my IDE. 8) I changed it at other similar places as well. In the other patches are other ones as well. But let us redo these after the merge.

> zzag wrote in drag_wl.cpp:297
> Please follow coding style, no short names.

cnt is used as an indexing variable. In this case short names are fine in my opinion. There are even people who use `i` for that I heard.

> zzag wrote in drag_wl.h:55
> Wouldn't it be better to use DndActions instead of CActions?

Yea, In the beginning there was also an SAction for the Server part of it, that's why the C. ;)

> zzag wrote in drag_x.cpp:126
> Seems to be redundant.

True, I still think one should do it always, even in a destructor.

REVISION DETAIL
  https://phabricator.kde.org/D15627

To: romangg, #kwin
Cc: zzag, kwin, alexde, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart