D15627: [xwl] Drag and drop between Xwayland and Wayland native clients

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in input.cpp:2095
> Why is it not the case? In the stacking_order only the managed ones are, not?

Because we don't have concept of managed windows for wayland clients.

> romangg wrote in clipboard.cpp:139
> It takes an xcb_xfixes_selection_notify_event_t struct pointer included from xcb/xfixes.h. When I reuse components from X libraries I use the legacy NULL, because I remember that it can lead to problem if one doesn't and then gives it back to a function from such a library.

> it can lead to problem if one doesn't

When?

Given that NULL has to evaluate to 0, I still suggest to use nullptr.

http://c-faq.com/null/machnon0.html

> romangg wrote in drag_wl.cpp:297
> cnt is used as an indexing variable. In this case short names are fine in my opinion. There are even people who use `i` for that I heard.

From coding style:

  Single character variable names can denote counters and temporary variables whose purpose is obvious

REVISION DETAIL
  https://phabricator.kde.org/D15627

To: romangg, #kwin
Cc: zzag, kwin, alexde, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart