D17265: Fix changing the number of rows via the dbus protocol
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> virtualdesktops.cpp:665-666
> }
> - //FIXME: how to avoid this?
> - m_isLoading = true;
> QString groupname;
Wasn't it removed in another revision? Also, unrelated whitespace change.
> virtualdesktops.cpp:758
>
> + for (int i = count() + 1; group.hasKey(QStringLiteral("Id_%1").arg(i)); i++) {
> + group.deleteEntry(QStringLiteral("Id_%1").arg(i));
Extra whitespace before `group`.
> virtualdesktops.cpp:763
> +
> +
> group.writeEntry("Number", count());
Extra empty line.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D17265
To: mart, #plasma, #kwin, hein, davidedmundson, graesslin
Cc: zzag, graesslin, davidedmundson, ngraham, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart