D15629: [xwl] text/x-uri converter for selected X url list format targets
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> drag_x.cpp:56
> + // text/x-uri and accept the information loss.
> + mimeTypes << "text/uri-list" << "text/x-uri";
> + } else {
QStringLiteral.
Also, I think it would simpler to just return, e.g.
return {QStringLiteral(), QStringLiteral()};
> selection.cpp:59
> + xcb_get_atom_name_reply_t *nameReply = xcb_get_atom_name_reply(xcbConn, nameCookie, NULL);
> + if (nameReply == NULL) {
> + return QString();
nullptr
> transfer.h:169
>
> +/*
> + * Compatibility receiver for clients only
/**
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D15629
To: romangg, #kwin
Cc: zzag, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart