D18127: [scripting] Make DBus invokable run method return result after execution

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In 403038 the user expected the DBus call to run to finish before
  processing the next request. For a singleshot script that makes a lot of
  sense, otherwise you have no idea when it finishes.
  
  This also allows us to return errors.
  
  CCBUG: 403038

TEST PLAN
  NUM=$(qdbus org.kde.KWin /Scripting org.kde.kwin.Scripting.loadScript /noFile.js Minimize)
  qdbus org.kde.KWin /$NUM org.kde.kwin.Scripting.run
  
    Error: org.kde.kwin.Scripting.FileError
    Could not open /noFile.js
  
  Running a real script behaved effectively the same as before.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18127

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/tabbox/CMakeLists.txt
  scripting/scripting.cpp
  scripting/scripting.h

To: davidedmundson, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart