D18132: Rework ShellClient fullscreen control

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  The ShellClient::setFullScreen method was a direct copy of the Client
  version.
  
  Straighten out the function logic now and align with modern coding style.
  
  In short we check:
  
  1. what the manual override window rule wants,
  2. if there is a change at all with this,
  3. if such a change is possible.
  
  And do:
  
  4. (un-)set the fullscreen,
  5. emit the changed signal.

TEST PLAN
  Manually, autotests pass.

REPOSITORY
  R108 KWin

BRANCH
  shellClientFullScreenable

REVISION DETAIL
  https://phabricator.kde.org/D18132

AFFECTED FILES
  shell_client.cpp
  shell_client.h

To: romangg, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart