D18128: Split up fullscreen able check into AbstractClient subclasses

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> client.cpp:590-596
> +    if (rules()->checkStrictGeometry(true)) {
> +        // check geometry constraints (rule to obey is set)
> +        const QRect fsarea = workspace()->clientArea(FullScreenArea, this);
> +        if (sizeForClientSize(fsarea.size(), SizemodeAny, true) != fsarea.size()) {
> +            return false; // the app wouldn't fit exactly fullscreen geometry due to its strict geometry requirements
> +        }
> +    }

We lose this path in ShellClient::isFullScreenable. Is there a reason for thta?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18128

To: romangg, #kwin
Cc: zzag, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.