D18128: Split up fullscreen able check into AbstractClient subclasses

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in client.cpp:590-596
> Wayland native clients can't dictate the compositor if fullscreen is possible or not. so we don't need to check if their geometry is restricted. At least the call to `AbstractClient::sizeForClientSize` in the case of ShellClient in the current version on master would imply this.

As far as I know, it depends on compositor's policies, e.g. if max size was set for a xdg-toplevel, then compositor can disallow the fullscreen state, though this is probably unrelated. I just wanted to make sure you did this on purpose.

> shell_client.cpp:951
> +        return false;
> +    }
> +    return !isSpecialWindow();

Should popups be fullscreen-able?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18128

To: romangg, #kwin
Cc: zzag, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart