D18146: [kcmkwin/kwindecoration] Fix save of theme name

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If a user saves a decoration that has a plugin but no theme we currently
  delete the entry saving just the plugin/library.
  
  This is an issue as on load we call:
  
    const QString plugin = config.readEntry("library", s_defaultPlugin);
    const QString theme = config.readEntry("theme", s_defaultTheme);
  
  That would give us a non-default library with the default theme name,
  which would be invalid.
  
  If compiled with Breeze s_defaultTheme is blank so this ends up being 
  effectively the same thing. In the normal case it will neither break 
  nor fix anything.

TEST PLAN
  None.
  Just happened to see it when doing a code review.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18146

AFFECTED FILES
  kcmkwin/kwindecoration/kcm.cpp

To: davidedmundson, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart