D18084: [kcmkwin/kwindecoration] Load KCM decorations properly
Valerio Pilo <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
vpilo added a comment. In D18084#390285 <https://phabricator.kde.org/D18084#390285>, @davidedmundson wrote: > > Try this. If it also doesn't work, I'll make a patch with debugging and will have to ask you to try it :) > > Lets go straight for that. > > If you have a patch that works but can't explain why I'll instantly reject it anyway. Sure, why not cut the chase :) > Also, we can't have a situation where both the C++ side and the QML side is responsible for setting the currentIndex on the model. If I can be sure that the QML is loaded when `load()` runs, I'll just ditch this initial theme variable nonsense that was there from the beginning. > > >> The UI expects all decorations in the model to have a 'theme name' > > Where? 'Twas a long day - I didn't mean the UI, but `DecorationsModel::findDecoration()` REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18084 To: vpilo, ngraham, davidedmundson, mart Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart