D18104: [kcmkwin/kwindecoration] Rework decorations buttons drag&drop tab

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> buttonsmodel.cpp:169
>         by one, as explained in the documentation:
>         http://doc.qt.nokia.com/qabstractitemmodel.html#beginMoveRows */
>      if (targetIndex > sourceIndex) {

This still applies.

You're not seeing it because you now add +1 in your QML side, but that makes the guard at the top wrong and the else statement here wrong.

I would suggest adding https://doc.qt.io/qt-5.11/qabstractitemmodeltester.html   whilst you're doing dev work and you'll see this crash.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18104

To: vpilo, #vdg, ngraham, #kwin, davidedmundson
Cc: davidedmundson, abetts, ngraham, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart