D18185: Rework Client fullscreen control

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  After fixing superficial issues go and work over Client's fullscreen control.
  This way we:
  
  - check first for what the rule wants uis to do,
  - do only proceed if there is a change from/to fullscreen
  - remove code, that becomes unneeded by this.
  
  This goes with the assumption, that the current fullscreen state is always
  correctly stored in the m_fullscreenMode variable, but the previous code
  implicitly did the same at numerous occasions, just not in a consistent
  manner.

TEST PLAN
  Manually and auto tests still pass.

REPOSITORY
  R108 KWin

BRANCH
  clientFullscreenCtrl

REVISION DETAIL
  https://phabricator.kde.org/D18185

AFFECTED FILES
  geometry.cpp

To: romangg, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart