D18157: Remove Client fullscreen hack

graesslin added a comment.


  In D18157#391138 <https://phabricator.kde.org/D18157#391138>, @romangg wrote:
  
  > In D18157#390707 <https://phabricator.kde.org/D18157#390707>, @graesslin wrote:
  >
  > > For safety I suggest to push after 5.15 has been branched off. That gives us more time to test that nobody still has that key around. Though it's unlikely.
  >
  >
  > Thanks for the feedback. If you also think this hack can be removed, then I'm not so worried about removing used functionality.
  
  
  I was worried when I saw the change, to be honest. So I did a check that it's not set anywhere. Given that this option is old and all configuration broke with the switch to Qt 5 this is probably safe to remove. I doubt that anybody relies on it as it's impossible that configuration options did the migration from KDE 3 to Plasma 5.
  
  > Just a question: what would be the outcome of somebody still having the key around (in the KWin config file)? I assumed it would just mean that the key would be ignored when reading out the file, but nothing more.
  
  Yes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18157

To: romangg, #kwin
Cc: zzag, graesslin, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart