D18153: Correct code style of Client fullscreen control
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added a comment. Well I always kept such old code as it was. I faced this problem a lot during the port to Wayland and introducing the AbstractClient. In the end I decided to not change anything that's in Client or Toplevel, but AbstractClient introduces the more "modern" approach. We just have to accept that KWin is an old application with several generations of developers. We can be sure that the next generation will also think that our naming was inconsistent and stupid. Personally I think it's not worth to try to adjust to the current "modern". REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18153 To: romangg, #kwin Cc: zzag, graesslin, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart