D18009: Add Findepoll.cmake to find epoll/epoll-shim and add initial FreeBSD support

graesslin added inline comments.

INLINE COMMENTS

> CMakeLists.txt:278
>  
> +find_package(epoll)
> +set_package_properties(epoll PROPERTIES DESCRIPTION "I/O event notification facility"

If this is FreeBSD specific it should be indicated so. Don't list it as an optional feature on platforms not affected. Please check whether it's needed and then turn it into a required feature on FreeBSD.

> CMakeLists.txt:528
>  
> -if (HAVE_LINUX_VT_H)
> +if (HAVE_LINUX_VT_H OR epoll_FOUND)
>          set(kwin_KDEINIT_SRCS

and if epoll becomes a required feature on FreeBSD we can remove this check here. No need to keep the special if for freebsd.

> virtual_terminal.cpp:88
>      }
> +#if defined(Q_OS_LINUX)
>      if (major(st.st_rdev) != TTY_MAJOR || minor (st.st_rdev) <= 0 || minor(st.st_rdev) >= 64) {

why is that linux specific?

> virtual_terminal.cpp:105-109
> +#if defined(Q_OS_FREEBSD)
> +    QString ttyName = QStringLiteral("/dev/ttyv%1").arg(vtNr);
> +#else
>      QString ttyName = QStringLiteral("/dev/tty%1").arg(vtNr);
> +#endif

this I would prefer if it goes through a configure file, so that we don't need the ifdef in code.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18009

To: tcberner, #automotive, #kwin, #freebsd
Cc: graesslin, kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart