D18210: Add addWindow and removeWindow to Scene

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Code that destroys all scene windows when finishing compositing is not
  readable. E.g. can you tell what this piece of code is doing without
  looking into the source code of Scene::windowClosed?
  
    foreach (Client * c, Workspace::self()->clientList())
        m_scene->windowClosed(c, NULL);
  
  This change intoduces removeWindow(as well its counterpart) method to
  the Scene class. The name of the new method much better describes what
  we're doing.

REPOSITORY
  R108 KWin

BRANCH
  tidy-scene

REVISION DETAIL
  https://phabricator.kde.org/D18210

AFFECTED FILES
  composite.cpp
  scene.cpp
  scene.h

To: zzag, #kwin
Cc: kwin, kvanton, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart