D18261: support decorations from lookandfeel

davidedmundson added a comment.


  Generally makes sense.
  Minor nitpicks, but otherwise +1
  
  In your commit message:
  s/kein/kwin

INLINE COMMENTS

> decorationbridge.cpp:85
>  {
> -    return kwinApp()->config()->group(s_pluginName).readEntry("library", s_defaultPlugin);
> +    QString plugin = s_defaultPlugin;
> +    //Try to get a default from look and feel

This local var is effectively unused.
"plugin" isn't a very helpful name as there are 3 potential plugins mentioned in this method.

It'll be clearer if the last line just uses s_defaultPlugin directly

I would also avoid "cg" because kwinApp->config() is also a cg.

This also applies for readTheme

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18261

To: mart, #plasma, #kwin
Cc: davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart