D18307: Call frameRendered for undamaged Wayland surfaces

davidedmundson added a comment.


  > This does not take into account: A server should avoid signaling the frame callbacks if the surface is not visible in any way,
  
  ToplevelList windows = Workspace::self()->xStackingOrder();
  
  This should exclude unmapped or minimised.
  
  > or completely obscured by other opaque surfaces.
  
  We don't do this now.
  
  > especially lockscreen
  
  There's a line above that removes from the "windows" list. (composite.cpp:740)
  
    foreach (Toplevel *t, windows) {
       if (waylandServer() && waylandServer()->isScreenLocked()) {
            if(!t->isLockScreen() && !t->isInputMethod()) {
                windows.removeAll(t);
            }
        }
  
  If anything, that means it was broken before and this fixes it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18307

To: ekurzinger, romangg, davidedmundson
Cc: graesslin, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart