D18328: Fix VirtualDesktopManager::createVirtualDesktop

davidedmundson added a comment.


  Changes definitely make sense, much more readable now.
  
  One minor comment, then ship it.

INLINE COMMENTS

> virtualdesktops.cpp:454
>      }
>  
>      auto *vd = new VirtualDesktop(this);

I think we need to validate that position <= count() either here or in the DBus wrapper.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18328

To: zzag, #kwin
Cc: davidedmundson, hein, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart