D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo created this revision.
Herald added a project: KWin.
Herald added a subscriber: kwin.
vpilo requested review of this revision.

REVISION SUMMARY
  - Wrote new KCM based on KQuickAddons::ConfigModule.
  - Remade QMLs for Buttons and Themes tabs, moved options to a third tab.
  - Updated bridge model code for new plugin lookup API (fixes warnings).
  - Fixed decoration shadow changing messing with the previews sizes.
  - Fixed drag and drop issues (see D18104 <https://phabricator.kde.org/D18104>).
  
  NOTE: There's a few FIXMEs in kcm.cpp - I need feedback!
  
  BUG: 389431
  BUG: 350122
  BUG: 346222
  BUG: 342816
  BUG: 397595

TEST PLAN
  - Verified saving and loading for every widget
  - Checked shadows of Breeze and Oxygen
  - Tested all possible drag&drop operations on both sides of the fake titlebar
  - Tested on a fresh Neon-developer account, via kcmshell and systemsettings

REPOSITORY
  R108 KWin

BRANCH
  vpilo/deco_rewrite

REVISION DETAIL
  https://phabricator.kde.org/D18458

AFFECTED FILES
  kcmkwin/kwindecoration/CMakeLists.txt
  kcmkwin/kwindecoration/Messages.sh
  kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
  kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.h
  kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewbutton.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
  kcmkwin/kwindecoration/decorationmodel.cpp
  kcmkwin/kwindecoration/decorationmodel.h
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.h
  kcmkwin/kwindecoration/kcm.ui
  kcmkwin/kwindecoration/kwindecoration.desktop
  kcmkwin/kwindecoration/package/contents/ui/ButtonGroup.qml
  kcmkwin/kwindecoration/package/contents/ui/Buttons.qml
  kcmkwin/kwindecoration/package/contents/ui/Options.qml
  kcmkwin/kwindecoration/package/contents/ui/Themes.qml
  kcmkwin/kwindecoration/package/contents/ui/main.qml
  kcmkwin/kwindecoration/package/metadata.desktop
  kcmkwin/kwindecoration/qml/ButtonGroup.qml
  kcmkwin/kwindecoration/qml/Buttons.qml
  kcmkwin/kwindecoration/qml/Previews.qml
  kcmkwin/kwindecoration/qml/main.qml
  kcmkwin/kwindecoration/utils.cpp
  kcmkwin/kwindecoration/utils.h
  kcmkwin/kwindecoration/window-decorations.knsrc

To: vpilo
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart