D18458: Rewrite the KWin decorations settings as a ConfigModule.

davidedmundson added a comment.


  Probably the best way to go.

INLINE COMMENTS

> kcm.cpp:45
> +/*
> +    FIXME In main.qml, In other modules and in the help the main item is just a child, not set as contentItem. But if placed as a child,
> +          the UI can be scrolled with press&drag and behaves erratically. What's wrong there?

See next comment

> kcm.cpp:50
> +    FIXME I get these warnings starting the module. Am I doing something wrong here?
> +    /usr/lib/x86_64-linux-gnu/qml/org/kde/kcm/SimpleKCM.qml:107: TypeError: Cannot read property 'atYBeginning' of null
> +    /usr/lib/x86_64-linux-gnu/qml/org/kde/kcm/SimpleKCM.qml:117: TypeError: Cannot read property 'atYEnd' of null

SimpleKCM expects there to be a central flickable Item

See the base class Kirigami.ScrollablePage

Given our main central item is the tabview we might be best off inheriting from Kirigami.Page

> kcm.cpp:53
> +    /usr/lib/x86_64-linux-gnu/qml/org/kde/kcm/SimpleKCM.qml:51: TypeError: Cannot read property 'contentHeight' of null
> +    /usr/lib/x86_64-linux-gnu/qt5/qml/QtQuick/Controls.2/org.kde.desktop/ComboBox.qml:137:29: Unable to assign [undefined] to QQmlComponent
> +*/

that's not your issue, ignore this one.

> kcm.cpp:145
> +/*
> + // FIXME dynamically add categories for installed themes?
> + // also FIXME verify list of Categories in .knsrc file

Can I check this FIXME is just a new idea and not a regression?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart