D18452: [autotests] Sub-surface resize test

zzag added inline comments.

INLINE COMMENTS

> buffer_size_change_test.cpp:5
> +
> +Copyright 2019 Roman Gilg <[email protected]>
> +

Nitpick: missing "(C)". :D

> buffer_size_change_test.cpp:21-23
> +#include "composite.h"
> +#include "wayland_server.h"
> +#include "shell_client.h"

Includes should be sorted.

> buffer_size_change_test.cpp:51
> +void BufferSizeChangeTest::testShmBufferSizeChange()
> +{
> +    using namespace KWayland::Client;

Missing "this test verifies ..."

> buffer_size_change_test.cpp:55
> +    QScopedPointer<Surface> surface(Test::createSurface());
> +    QVERIFY(!surface.isNull());
> +

Just QVERIFY(surface);

> buffer_size_change_test.cpp:57
> +
> +    QScopedPointer<ShellSurface> shellSurface(Test::createShellSurface(surface.data()));
> +    QVERIFY(!shellSurface.isNull());

Why ShellSurface?

> buffer_size_change_test.cpp:59
> +    QVERIFY(!shellSurface.isNull());
> +    Test::flushWaylandConnection();
> +

Could you please add an explanatory comment for this flush?

> buffer_size_change_test.cpp:79
> +    QVERIFY(swapSpy.wait());
> +}
> +

Also, it would be great to destroy the client, though that's not mandatory. :-)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18452

To: romangg, #kwin
Cc: zzag, graesslin, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart