D18458: Rewrite the KWin decorations settings as a ConfigModule.

broulik added a comment.


  I must say, very tasteful "Buttons" page! :)
  
  I think the Theme grid should use the same `GridView` stuff we use in other KCMs, to provide a unified look, perhaps with a bigger grid size to accomodate for the increased complexity of the preview.
  
  And yes, please add some screenshots for VDG

INLINE COMMENTS

> kcm.cpp:222
>  {
> -    auto it = s_sizes.constFind(name);
> -    if (it == s_sizes.constEnd()) {
> -        // non sense values are interpreted just like normal
> -        return BorderSize::Normal;
> +    // FIXME Check why the "Defaults" button gets never enabled neither in kcmshell nor systemsettings
> +

There's a typo in the QML, it is `KCM.ConfigModule.Default` (without an "s").

However, you seem to be doing it from both QML and C++ (`setButtons()`), one is sufficient. (I have seen this mistake in other QML KCMs, I assume you just copied that over)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart