D18486: [RFC] XWayland Multi DPI support

zzag added inline comments.

INLINE COMMENTS

> abstract_output.cpp:98
>          // don't treat this like it's chosen deliberately
> -        m_waylandOutput->setScale(std::ceil(scale));
> +        m_waylandOutput->setScale(std::ceil(scale - 0.05));
>      }

Could you please explain what it is doing?

> scene_opengl.cpp:1486-1488
> +    if (textureFilter = GL_LINEAR) {
> +        s_frameTexture->generateMipmaps();
> +    }

I think GL_LINEAR shouldn't be used in this case. Why mipmaps anyway? I don't see where the number of levels is set.

> xcbutils.h:55-85
> +template <typename T>
> +static T scX(T arg)
> +{
> +    return arg * kwinApp()->x11Scale();
> +}
> +
> +template <typename T>

Please follow coding style, no short names.

> xcbutils.h:64
> +{
> +    auto ret = arg / (double)kwinApp()->x11Scale() + 0.5;
> +    T ret2 = ret;

It will return a wrong value if qreal is passed.

> xcbutils.h:1816
>  {
> +    const QRect rectSc = scX(rect);
>      xcb_rectangle_t rectangle;

Please follow coding style.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18486

To: romangg, #kwin
Cc: zzag, davidedmundson, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart