D18464: [autotests] Rewrite testShellClientRules
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added inline comments.
INLINE COMMENTS
> shell_client_rules_test.cpp:186
> {
> + QSKIP("Window rules do not work well on Wayland");
> +
I don't really understand this. Before we had a test which tested the aspects already supported. For every added supported rule the test was added. Obviously this was not complete, it's not news that rules are fully implemented yet.
Now we have more test cases also for the things not yet supported, but the complete test is skipped. Thus also the already working aspects are not covered. I don't understand what the advantage is.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D18464
To: zzag, #kwin
Cc: graesslin, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart