D18458: Rewrite the KWin decorations settings as a ConfigModule.

broulik added inline comments.

INLINE COMMENTS

> Themes.qml:52
> +    }
> +    view.highlight: Rectangle {
> +        color: PlasmaCore.ColorScope.highlightColor

I think this can go with the `GridDelegate`

> Themes.qml:56
> +    }
> +    view.delegate: Item {
> +        width: view.cellWidth - cellSpacing

This should be using `KCM.GridDelegate` for consistency with the other grid-based KCMs

> Themes.qml:107
> +        }
> +        Controls.Button {
> +            id: configureButton

Use `actions` property on the `GridDelegate` instead

  actions: [
      Kirigami.Action {
          iconName: "configure"
          tooltip: i18n("Configure")
          enabled: model.configureable
          ...
      }
  ]

> main.qml:25
> +import org.kde.kwin.private.kdecoration 1.0 as KDecoration
> +import org.kde.plasma.core 2.0 as PlasmaCore
> +

Please cleanup the imports, here, and everywhere else :)

> main.qml:31
> +
> +    flickable.boundsMovement: Flickable.StopAtBounds
> +    flickable.flickableDirection: Flickable.AutoFlickIfNeeded

Is this needed?

> main.qml:59
> +    footer: RowLayout {
> +        Layout.alignment: Qt.AlignRight
> +

This doesn't seem to work, the button is left-aligned for me and has some odd padding above it

> main.qml:65
> +            onClicked: kcm.getNewStuff(this)
> +        }
> +    }

please add

  visible: KAuthorized.authorize("ghns")

using `import org.kde.kconfig 1.0 // for KAuthorized`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart