D18458: Rewrite the KWin decorations settings as a ConfigModule.

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Cool stuff. I ran into some issues and have a few visual suggestions.
  
  1. Applying the patch and building KWin didn't actually make the new KCM appear anywhere in System Settings for me. The old KCM was still there in its place.
  2. Going by the screenshots, we should try to use the GridView style of other recently-rewritten KCMs, like Icons, Colors, Plasma theme etc
  3. Let's try to use the multi-page navigation pattern rather than tabs. QQC2 Tabs are full of visual problems right now, as your screenshots illustrate.
  4. Instead of creating a third tab/page for just two options, let;s move those back where they were before, as footers for the grid view.
  5. "Get New Decorations" should retain its old text and position; it needs to say "Get New Window Decorations" and be in the bottom-right.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart