D18458: Rewrite the KWin decorations settings as a ConfigModule.

Valerio Pilo <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
vpilo updated this revision to Diff 50330.
vpilo marked 6 inline comments as done.
vpilo added a comment.


    - Review comments
  - Fixed imports in all QML files.
  - Rewrote the Themes grid delegate into KCM.GridDeletgate. Looks much better now.
  - Fixed layouting/sizing issues of the main gridview and GHNS button.
  - GHNS: Re-added KAuthorized, changed button label.
  - Added animation to explanatory label of closeOnDoubleClickOnMenu option.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18458?vs=50150&id=50330

BRANCH
  vpilo/deco_rewrite

REVISION DETAIL
  https://phabricator.kde.org/D18458

AFFECTED FILES
  kcmkwin/kwindecoration/CMakeLists.txt
  kcmkwin/kwindecoration/Messages.sh
  kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp
  kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.h
  kcmkwin/kwindecoration/declarative-plugin/previewbridge.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewbutton.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewclient.cpp
  kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
  kcmkwin/kwindecoration/decorationmodel.cpp
  kcmkwin/kwindecoration/decorationmodel.h
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.h
  kcmkwin/kwindecoration/kcm.ui
  kcmkwin/kwindecoration/kwindecoration.desktop
  kcmkwin/kwindecoration/package/contents/ui/ButtonGroup.qml
  kcmkwin/kwindecoration/package/contents/ui/Buttons.qml
  kcmkwin/kwindecoration/package/contents/ui/Options.qml
  kcmkwin/kwindecoration/package/contents/ui/Themes.qml
  kcmkwin/kwindecoration/package/contents/ui/main.qml
  kcmkwin/kwindecoration/package/metadata.desktop
  kcmkwin/kwindecoration/qml/ButtonGroup.qml
  kcmkwin/kwindecoration/qml/Buttons.qml
  kcmkwin/kwindecoration/qml/Previews.qml
  kcmkwin/kwindecoration/qml/main.qml
  kcmkwin/kwindecoration/utils.cpp
  kcmkwin/kwindecoration/utils.h
  kcmkwin/kwindecoration/window-decorations.knsrc

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.