D17900: Introduce a dynamic enabled mode in virtual keyboard

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added a comment.


  In D17900#400841 <https://phabricator.kde.org/D17900#400841>, @graesslin wrote:
  
  > If there are no objections I'm going to push this
  
  
  I wish I could test this patch, but I don't own any device with touchscreen.

INLINE COMMENTS

> virtualkeyboard.cpp:176-177
>          [this] {
> -            setEnabled(!m_enabled);
> +            switch (m_mode)
> +            {
> +            case Mode::Disabled:

Style.

> virtualkeyboard.cpp:545-546
> +{
> +    switch (m_mode)
> +    {
> +    case Mode::Disabled:

Style.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17900

To: graesslin, #kwin
Cc: zzag, mart, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.