D18570: EGLStream DRM Backend Initial Implementation

zzag added inline comments.

INLINE COMMENTS

> drm_backend.cpp:614
>  
> +void DrmBackend::queuePageFlip() {
> +    ++m_pageFlipsPending;

Functions have opening braces on the start of a line.

> drm_backend.cpp:751
>  {
> +    if (m_useEglDevice) {
> +        m_deleteBufferAfterPageFlip = false;

It would be great if EGLStreams were optional.

> egl_stream_backend.cpp:88-98
> +            [this] (DrmOutput *output) {
> +                auto it = std::find_if(m_outputs.begin(), m_outputs.end(),
> +                                       [output] (const Output &o) {
> +                                           return o.output == output;
> +                                       });
> +                if (it == m_outputs.end()) {
> +                    return;

Please indent the lambda with 4 spaces. The pattern looks like as follows

  connect(sender, &Sender::changed, context,
      [this](Value *value) {
          // Body
      }
  );

> egl_stream_backend.cpp:278
> +    wl_resource_set_implementation(resource, (void *)&eglStreamControllerImplementation,
> +                                   data, NULL);
> +}

Please use nullptr.

> egl_stream_backend.cpp:300
> +    if (!lib) {
> +        goto fail;
> +    }

Please no `goto`. Use a lambda.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18570

To: ekurzinger, romangeints, davidedmundson, graesslin, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart