D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  In D18458#400473 <https://phabricator.kde.org/D18458#400473>, @ngraham wrote:
  
  > Ah, thanks for the info. Now I can see it. Lovely work! I can't wait to ship this.
  >
  > A few new comments:
  >
  > - If you made the grid view delegates a bit smaller, we could fit two rows into the grid with System Settings' default window size.
  
  
  Done. If David/I/anyone manage to find out why the gridview doesn't properly resize along with the rest of the window, its default size should now have plenty of space.
  
  > - The inline "Configure" buttons should match the Plasma Theme and Colors KCMs and say "Edit <theme name> Theme" and use the `edit-entry` icon.
  
  Okay.. Done. I can get behind standardizing, but I liked better the paintbrush icon for those buttons, since they're refining how the themes look 😬
  
  > - By making the Edit/Configure button once again text-less, we'll be effectively reverting the fix for re-open https://bugs.kde.org/show_bug.cgi?id=390245, which was done in D11201 <https://phabricator.kde.org/D11201>. This is a general problem with these new-style KCMs that's tracked with https://bugs.kde.org/show_bug.cgi?id=395510, but it's worth maybe putting some more thought into that since the scope of the problem will expand as more KCMs are ported.
  
  I guess once that framework issue is fixed we can come back to this. At least with this change, one more kcm will have the new standardized look.
  In the future, the default button look can be changed to make buttons in all KCMs look more obvious.
  
  > - The tabbed view suffers from the problems outlined in https://bugs.kde.org/show_bug.cgi?id=394295 and https://bugs.kde.org/show_bug.cgi?id=394296. We really need to get those fixed...
  
  Shall we finalize this huge change first, and then find out how to replace the tabs? I'm also not a fan, but I couldn't find another decent way - except making two separate KCMs, not really a good option.
  
  > - On the Buttons page, the buttons are very difficult to see because everything is gray-on-gray: gray square background, gray shadow, gray icon, etc. We need radically more contrast here. For a start, I would remove the shadows. They don't add anything and reduce contrast.
  
  I tinted them to always have the same color of the fake titlebar text. They now look fine to me with all default KDE color schemes, would you agree with me? (see screenshot)
  
  > - Could we maybe change the name of the "Buttons" tab to "Titlebar Buttons" That would make it a bit more obvious, I think.
  
  Another good idea; done!
  
  > - While you're re-doing this, let's change the `Comment` in the desktop file to say something different. The current string "Look and Feel of Window Titles" is not accurate and does not follow use the correct formatting (should be in Sentence case and begin with a verb). Maybe something like "Configure window shadows, borders, and titlebars".
  
  I raise you "Configure window appearance, borders, and buttons"
  
  > And then that string should be repeated in the `KAboutData` (or ideally it should just read the string from the desktop file instead of duplicating it in the code).
  
  I have no idea whether there's any facility for this purpose. It sounds very messy work to read a file (from which path?) only to show one label in the about screen. Duplication sure seems easier..
  
  > Thanks again for your awesome work on this!
  
  My pleasure 😊

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart