D18570: EGLStream DRM Backend Initial Implementation

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Context is missing. Do `git diff -U 99999` to include it.
  
  At few points native Wayland structs are used. We should strive for using KWayland in these cases instead (and remove the direct library link in this diff again). Can you wrap these structs up into CPP KWayland objects?

INLINE COMMENTS

> egl_stream_backend.cpp:404
> +    Output o;
> +    if (resetOutput(o, drmOutput)) {
> +        connect(drmOutput, &DrmOutput::modeChanged, this,

To reduce indent, do instead:

  if (!resetOutput(o, drmOutput)) {
      return;
  }
  ...

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18570

To: ekurzinger, romangeints, davidedmundson, graesslin, #kwin, romangg
Cc: romangg, hein, nicolasfella, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart