D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  In D18458#401549 <https://phabricator.kde.org/D18458#401549>, @ngraham wrote:
  
  > We're getting there! The exceeding-bounds layout issue is fixed now, which is nice. However I can still reproduce the issue where the combobox only has two entries, but scrolling over it shows the full assortment ! Very odd. And there's also an odd amount of space between the controls in the footer:
  >
  > F6573899: Screenshot_20190128_155228.png <https://phabricator.kde.org/F6573899>
  
  
  Yes that space is the layouting issue. I am using gammaray to try and investigate the source of both this and the combobox.
  
  >> hmm then "Configure window titlebar, borders, buttons" as many themes have no shadows? If that's not an issue I'm fine with shadows too.
  > 
  > The problem is that the word "buttons" is unclear. What is a window button? To the user, a window button is a button in the window. This KCM is specifically about window //titlebar// buttons, not buttons in general. I could go with "Configure window titlebars and borders" since technically the shadow (if present) is a part of the border
  
  That's better for me too, and more concise at that. Let's go with that.
  
  > Finally, I notice you made the shadows harder on the Titlebar Buttons tab. It makes me wonder whether we even need them at all. I think it looks better without them:
  > 
  > F6573905: Screenshot_20190128_155928.png <https://phabricator.kde.org/F6573905>
  
  oook they look //fancy// but maybe a bit overkill 👼

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart