D18458: Rewrite the KWin decorations settings as a ConfigModule.

ngraham added a comment.


  Awesome! Most of my UI issues have been resolved, and this is looking pretty great. The only remaining issues are the comments I've left inline, plus the known issue of excessive padding in the footer items.

INLINE COMMENTS

> kcm.cpp:90
> +    KAboutData* about = new KAboutData(QStringLiteral("kcm_kwindecoration"),
> +                                       i18n("Configure Window Decorations"),
> +                                       QStringLiteral("1.0"),

The string from the`Comment` in the desktop file needs to be duplicated here.

> kwindecoration.desktop:76
> +Comment=Configure window titlebars and borders
> +Comment[en_GB]=Configure window titlebars and borders
> +Comment[it]=Configura barra del titolo e bordi delle finestre

Don't add other languages here, even for languages that you speak. Let the translation team handle this. :)

> metadata.desktop:78
> +Comment=Configure window titlebars and borders
> +Comment[en_GB]=Configure window titlebars and borders
> +Comment[it]=Configura barra del titolo e bordi delle finestre

Same.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, ngraham, #kwin
Cc: broulik, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart