D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  OK. As I thought then,
  
  In D18458#401828 <https://phabricator.kde.org/D18458#401828>, @GB_2 wrote:
  
  > Looks great!
  >  The close button is a bit hard to see though.
  
  
  I don't know how else to tint these icons to the theme color without messing with their shapes. I welcome suggestions :D

INLINE COMMENTS

> zzag wrote in previewbutton.cpp:135
> Doesn't QQuickItem have size() method?

Everything else can take/return real, but DecorationButton::paint() can only take a QReal so I thought to reduce conversions this way

> zzag wrote in decorationmodel.cpp:173
> It seems like that's unrelated change.

it's not, findDecoration() below might fail to find a theme because it only searches for `themeName` and not on `visibleName`

> zzag wrote in decorationmodel.h:36
> Can't we start from Qt::UserRole +1?

It came all the way from 2014 somehow.. I'm not nostalgic. Done

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, #kwin
Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart