D18458: Rewrite the KWin decorations settings as a ConfigModule.

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in previewbridge.cpp:133
> In KWin, we tend to use constBegin/constEnd.

This isn't done, below `cend` is used.

> zzag wrote in previewbutton.h:62
> const QColor &color

This isn't done.

> vpilo wrote in decorationmodel.cpp:173
> it's not, findDecoration() below might fail to find a theme because it only searches for `themeName` and not on `visibleName`

Introduction of `name` variable is unrelated change. Given that `info` is a const ref, I think we can do

  data.visibleName = info.name().isEmpty() ? info.pluginName() : info.name();
  data.themeName = data.visibleName;

> vpilo wrote in decorationmodel.h:36
> It came all the way from 2014 somehow.. I'm not nostalgic. Done

We don't need `+2`, and `+3`.

> kcm.cpp:90-93
> +                                       i18n("Configure window titlebars and borders"),
> +                                       QStringLiteral("1.0"),
> +                                       QString(),
> +                                       KAboutLicense::GPL);

Please align it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, #kwin
Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart