D18458: Rewrite the KWin decorations settings as a ConfigModule.
Valerio Pilo <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
vpilo added inline comments. INLINE COMMENTS > zzag wrote in decorationmodel.cpp:173 > Introduction of `name` variable is unrelated change. Given that `info` is a const ref, I think we can do > > data.visibleName = info.name().isEmpty() ? info.pluginName() : info.name(); > data.themeName = data.visibleName; Ah right- it only made sense before I ditched the GHNS id->name data map. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18458 To: vpilo, #vdg, abetts, davidedmundson, #kwin Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart