D18458: Rewrite the KWin decorations settings as a ConfigModule.

vpilo added a comment.


  In D18458#402215 <https://phabricator.kde.org/D18458#402215>, @ngraham wrote:
  
  > In D18458#402027 <https://phabricator.kde.org/D18458#402027>, @vpilo wrote:
  >
  > > I don't know how else to tint these icons to the theme color without messing with their shapes. I welcome suggestions :D
  >
  >
  > If we can make the titlebar and buttons on that tab look exactly like they do in the theme itself, that would seem to present a solution to the issue. Then but roundrects behind the draggable buttons on bottom could just use the titlebar color.
  
  
  It's really messy to have that. I tried and it would require either:
  
  1. allowing access to the faux titlebar button models (but I think the biggest problem would be matching their actual location when trying to drag them in and out), or
  2. duplicating the entire thing, using the current system without actually painting anything, and have an actual decoration drawn underneath. And here, being sure the current model matches the deco underneath would be quite hard.
  
  Also I am not sure whether it would actually be worth taking all that time implementing such solutions, when this one has just a slight contrast issue. For sure I would not do all that as part of this change, to not let it drag along too long.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, davidedmundson, #kwin
Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart