D18458: Rewrite the KWin decorations settings as a ConfigModule.

Valerio Pilo <[email protected]> Thu, 31 Jan 2019 01:11:42 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

vpilo added a comment.

  In D18458#402523 <https://phabricator.kde.org/D18458#402523>, @davidedmundson wrote:

  > TabBar still needs some work, but on the QQC-desktop-theme side.
  >
  > And there's some problems with the outside border, it should line up with the left edge of the "help" button, it does in kcmshell not in systemsettings. 
  >  I fear that's the declarative KCM embedding which ended up quite convoluted :/

  Now I think that SimpleKCM needs to be remade like GridKCM is. Or that all *KCM items should inherit from SimpleKCM. This way we can be sure they will all look the same.

  This version at least behaves fine in systemsettings5, but the borders are not right in kcmshell. I think the only one that matters is systemsettings, right?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, #kwin, davidedmundson
Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart