D18570: EGLStream DRM Backend Initial Implementation
Erik Kurzinger <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ekurzinger added inline comments. INLINE COMMENTS > romangg wrote in drm_backend.cpp:642 > Not in this diff though. Same holds for other suggestions below in this file, which are not directly related to this diff. yeah, while I agree with these suggestions I think it would be best to limit this commit to code related to the new backend as opposed to general cleanup. I'll address the style issues you noticed in egl_stream_backend.cpp, though (thanks for catching those). > cfeck wrote in egl_stream_backend.cpp:188 > `ext` is only a byte array. To add it to a string, Qt needs to know in which encoding the byte array is. Please use `... + QLatin1String(ext)`. I believe QString::operator+ does this implicitly REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18570 To: ekurzinger, davidedmundson, graesslin, #kwin, romangg Cc: fredrik, cfeck, rapiteanu, romangg, hein, nicolasfella, zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart