D15629: [xwl] text/x-uri converter for selected X url list format targets

zzag added inline comments.

INLINE COMMENTS

> selection.cpp:54-67
> +QString Selection::atomName(xcb_atom_t atom)
> +{
> +    auto *xcbConn = kwinApp()->x11Connection();
> +    xcb_get_atom_name_cookie_t nameCookie = xcb_get_atom_name(xcbConn, atom);
> +    xcb_get_atom_name_reply_t *nameReply = xcb_get_atom_name_reply(xcbConn, nameCookie, NULL);
> +    if (nameReply == NULL) {
> +        return QString();

Can't we use Xcb::Atom instead?

> transfer.cpp:486-506
> +    while (start < length) {
> +        auto part = QByteArray::fromRawData(value + start, length - start);
> +        const int linebreak = part.indexOf('\n');
> +        if (linebreak == -1) {
> +            // no more linebreaks, end of work
> +            if (!remLine) {
> +                // append the rest

Could you please clarify format of NETSCAPE_URL? According to https://chromium.googlesource.com/chromium/src/+/3624c6c095108839db78c01dce92c731cf10b954/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc#178 it looks we don't need this loop.

Why do we have to remove each second line?

> transfer.h:172
> + * supporting the NETSCAPE_URL scheme (Firefox)
> + */
> +class NetscapeUrlReceiver : public DataReceiver

**/

see D18683 <https://phabricator.kde.org/D18683>

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15629

To: romangg, #kwin
Cc: zzag, kwin, jraleigh, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart