D18458: Rewrite the KWin decorations settings as a ConfigModule.

davidedmundson added a comment.


  Maybe change the subject line to start with [kcmkwin/kwindecoration] though we don't have a very good policy on this.
  
  two minor comments left, and then I think we're good to ship this

INLINE COMMENTS

> main.qml:76
> +                            Layout.alignment: Qt.AlignRight
> +                            text: i18ndc("kcm_kwindecoration", "combobox label", "Window border size:")
> +                        }

context /should/ be set automagically

And surely it would be kcmkwindecoration not  kcm_kwindecoration ?

> main.qml:109
> +                        checked: kcm.closeOnDoubleClickOnMenu
> +                        onCheckedChanged: {
> +                            kcm.closeOnDoubleClickOnMenu = checked

onToggled

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18458

To: vpilo, #vdg, abetts, #kwin, davidedmundson
Cc: zzag, GB_2, ngraham, broulik, kwin, jraleigh, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart